[WASH-933] Add read record method to iOS Plugin #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrhea
requested review from
efabens,
galxy25,
pirtleshell,
carrala,
rosasck and
sjonz
- Adds readRecord method to Flutter iOS Plugin - Includes a typo fix to main.dart Method confirmed to work by adding a call to readRecord into the onWriteRecordButtonPress.
Mrhea
force-pushed
the
wash-933-read-record
branch
from
716d65d
to
647fa6b
Compare
galxy25
reviewed
Aug 3, 2021
| group.enter() | ||
| DispatchQueue.global().async { | ||
| /// Does not sanity check `uuidString`, so forced unwrap may fail | ||
| client.read(recordId: UUID(uuidString: recordID)!) { (readResult) in |
There was a problem hiding this comment.
thankfully the swift sdk should be enforcing type safety for us
galxy25
approved these changes
Aug 3, 2021
carrala
approved these changes
Aug 4, 2021
pirtleshell
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main.dartMethod confirmed to work by adding a call to
readRecordintoonWriteRecordButtonPress.