Update dependencies and deprecated URL #9
Conversation
Needs to be cleaned up still
android/build.gradle
Outdated
| transitive = true | ||
| } | ||
|
|
||
android/build.gradle
Outdated
| @@ -6,7 +6,7 @@ buildscript { | |||
| google() | |||
| jcenter() | |||
| mavenCentral() | |||
| maven { url "https://dl.bintray.com/terl/lazysodium-maven" } | |||
| maven { url "http://github.com/terl/lazysodium-android" } | |||
There was a problem hiding this comment.
I wonder if theres a way to not import a github url! I left our conversation thinking about how it may be slow
There was a problem hiding this comment.
Would this be better? https://mvnrepository.com/artifact/com.goterl.lazycode/lazysodium-java
There was a problem hiding this comment.
Oops ya, I just grabbed that from maven central as an example but probably would have used it. Thanks for catching that
There was a problem hiding this comment.
check if it works, not sure if it will i get a 404
There was a problem hiding this comment.
Lazy sodium 5.x should be pulled from maven central without a custom import. But if it isn't working I will dig in at a later date because I am not supposed to be commenting today
| dart_style: | ||
| dependency: transitive | ||
| description: | ||
| name: dart_style | ||
| url: "https://pub.dartlang.org" | ||
| source: hosted | ||
| version: "1.3.11" |
There was a problem hiding this comment.
can you update the read me with the "pub get outdated" and "pub get dependencies"
android/build.gradle
Outdated
| } | ||
|
|
||
| implementation ('com.tozny.e3db:e3db-client-android:6.0.2@aar'){ | ||
| implementation ('com.tozny.e3db:e3db-client-android:7.2.1@aar'){ |
Bintray is deprecated, so the app fails to run with a 403 error trying to get lazysodium. This PR fixes that issue and updates the project's dependencies.