Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move whenCalledWith closer to expectBoundFunction #53

Closed
tp opened this issue Apr 26, 2019 · 4 comments · Fixed by #58
Closed

Move whenCalledWith closer to expectBoundFunction #53

tp opened this issue Apr 26, 2019 · 4 comments · Fixed by #58
Assignees

Comments

@tp
Copy link
Owner

tp commented Apr 26, 2019

Sounds good, let's do the change in a different PR though

Originally posted by @HenriBeck in https://github.com/tp/tsaga/diffs

@tp tp self-assigned this Apr 26, 2019
@tp
Copy link
Owner Author

tp commented Apr 26, 2019

@HenriBeck I'd like to tackle this over the weekend to stay familiar with the code base.

@HenriBeck
Copy link
Collaborator

@tp any news on this? We will start with tsaga now and I would like to start using the ”final” testing implementation then to not introduce another change in a few weeks

@tp
Copy link
Owner Author

tp commented Apr 30, 2019

@HenriBeck Sorry, didn't get to it yet (who would've thought that 2 20 minute tasks are too much to take…). But I'll do it right now :)

@tp
Copy link
Owner Author

tp commented Apr 30, 2019

@HenriBeck Your approach of overlaying the interface on top of the implementation is very nice. Just have to shuffle a few interfaces instead of having to mess with lots of implementation code 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants