Add support for testing bound effects #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HenriBeck Do you still use these in app? I was hoping with the switch to TS 3.4 we could drop them entirely, just kept them around for legacy reasons. I mean, I wouldn't want anyone writing the anew & then write tests for them unless they must do so due to being stuck on 3.3. (as OMS is). Will have a look at the changes later today! |
tp
reviewed
Apr 24, 2019
tp
reviewed
Apr 24, 2019
tp
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way of testing your bound functions, so I created a similar interface for it as the saga test.
The only difference is that we are calling and expecting a return value instead of just dispatching an action. Asserting the return value is currently optional though this might not want we want.