Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scaffold): change console error to warn to reduce alert noise #88

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

chin2km
Copy link

@chin2km chin2km commented Jul 5, 2023

this console error creates a lot of noise in the alerts.
Just a warning would be enough and is a quick win without refactoring legacy code

Copy link
Owner

@tp tp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, as it's called on purpose it does not warrant any extra attention even.

Not sure why we didn't add better debugging hooks here (like an option to be silent by default).

@tp tp merged commit 2b2274b into tp:master Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants