Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't use sample as a global #9

Closed
tpapp opened this issue Mar 21, 2018 · 4 comments
Closed

don't use sample as a global #9

tpapp opened this issue Mar 21, 2018 · 4 comments
Labels
decision docs

Comments

@tpapp
Copy link
Owner

tpapp commented Mar 21, 2018

Eg in examples and docstrings. Conflicts with StatsBase.sample.
@tpapp
Copy link
Owner Author

tpapp commented Mar 21, 2018

possible alternatives:

  1. chain (used by Klara.jl),
  2. samples (simply the plural),
  3. sim (used by Mamba.jl)

@gabrielgellner
Copy link

I have been using samp if avoiding overlap with Klara.jl is wanted. Using samples feels a bit to similar to what you are trying to avoid shadowing :)

@tpapp tpapp added the docs label May 2, 2018
@tpapp
Copy link
Owner Author

tpapp commented Aug 30, 2018

I think I will go with chain when I revamp the docs (soon).

@tpapp tpapp added the decision label Aug 30, 2018
@tpapp tpapp mentioned this issue Dec 25, 2018
Closed
@tpapp
Copy link
Owner Author

tpapp commented Aug 19, 2019

Closed by #44, which uses a different API.

@tpapp tpapp closed this as completed Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
decision docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tpapp @gabrielgellner