feat(string generation): Adding FuzzerStrings to generate adjective b… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 30, 2020 13:19
|
Thank you very much for your contribution. Next time, could you please add documentation to every public types and members? (I'll do it for you this time). FYI, I extracted a new IProvideCorePrimitivesToFuzzer interface to IFuzz so that types aggregated by a Fuzzer instance can receive a reference to this tiny interface in their constructor => to avoid every one of them to reimplement methods such as HeadOrTails() etc. |
tpierrain
reviewed
Dec 3, 2020
| @@ -60,6 +60,8 @@ public Fuzzer(int? seed = null, string name = null) | |||
|
|
|||
| _internalRandom = new Random(seed.Value); | |||
|
|
|||
| _fuzzStrings = new FuzzerStrings(_internalRandom); | |||
There was a problem hiding this comment.
FYI I will instead provide a reference to this as a IProvideCorePrimitivesToFuzzer to the FuzzerStrings (BTW, I would like to rename it StringFuzzer if you don't mind)
tpierrain
reviewed
Dec 3, 2020
|
|
||
| namespace Diverse | ||
| { | ||
| public static class Adjectives |
There was a problem hiding this comment.
I will add a public comment for this type here.
tpierrain
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ased on feeling.
This first step is to generate adjectives. The idea would be able to generate complete sentence for random description.