Support alternative Azure deployments for Microsoft Graph #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously Microsoft Graph only worked for the default Azure deployment. However, there are currently three other national clouds supported in Azure (https://docs.microsoft.com/en-us/graph/deployments). This commit adds support for the `graph_endpoint` and `azure_ad_endpoint` to enable support for these alternative Azure deployments. Closes #139
* `password` was not necessary * `azure_ad_endpoint` defaults to https://login.microsoftonline.com * `graph_endpoint` defaults to https://graph.microsoft.com
stanhu
added a commit
that referenced
this pull request
Mar 15, 2022
This pulls in #140 to support other Azure deployments, such as Microsoft Cloud for US Government.
maxlazio
pushed a commit
to gitlabhq/omnibus-gitlab
that referenced
this pull request
Mar 16, 2022
Previously Microsoft Graph only worked for the default Azure deployment. However, there are currently three other national clouds supported in Azure (https://docs.microsoft.com/en-us/graph/deployments). This update adds support for the `graph_endpoint` and `azure_ad_endpoint` to enable support for these alternative Azure deployments. This pulls in tpitale/mail_room#140 to address tpitale/mail_room#139. Changelog: changed
tnir
pushed a commit
to tnir/charts-gitlab
that referenced
this pull request
May 16, 2022
Previously Microsoft Graph only worked for the default Azure deployment. However, there are currently three other national clouds supported in Azure (https://docs.microsoft.com/en-us/graph/deployments). This commit upgrades MailRoom to v0.0.20 to pull in tpitale/mail_room#140 to make it possible to configure endpoints for alternative Azure deployments. This update also adds support for the `azureAdEndpoint` and `graphEndpoint` configuration settings for incoming e-mail and Service Desk. Related CNG change: https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/931 Related Omnibus change: https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/5978 Upstream issue: tpitale/mail_room#139 Changelog: changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Microsoft Graph only worked for the default Azure deployment. However, there are currently three other national clouds supported in Azure (https://docs.microsoft.com/en-us/graph/deployments).
This commit adds support for the
graph_endpointandazure_ad_endpointto enable support for these alternative Azure deployments.Closes #139