Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link against proper TCTI library. #6

Closed
flihp opened this issue Nov 18, 2015 · 0 comments · Fixed by #9
Closed

Link against proper TCTI library. #6

flihp opened this issue Nov 18, 2015 · 0 comments · Fixed by #9
Assignees
@flihp
Labels
bug
Milestone
packaging

Comments

@flihp
Copy link
Contributor

flihp commented Nov 18, 2015

We shouldn't be building and linking in code from the SAPI source tree directly.
@flihp flihp added the bug label Nov 18, 2015
@flihp flihp self-assigned this Nov 18, 2015
@flihp flihp added this to the packaging milestone Nov 18, 2015
@flihp flihp mentioned this issue Nov 18, 2015
Closed
flihp added a commit to flihp/tpm2-tools that referenced this issue Nov 18, 2015
@flihp
build: Link against libtpm2tctisock.
e48addb 
This removes the immediate dependency on the socket TCTI sources
from the TPM2.0-TSS source tree resolving tpm2-software#6.

The code in the TPM2.0-TSS that this repo builds manually still
references this code (since it's local to that source tree) and
so these headers must remain in the C*FLAGS variable via -I. We
can't resolve this yet without sorting out an approach to tpm2-software#5.

Signed-off-by: Philip Tricca <philip.b.tricca@intel.com>
flihp added a commit to flihp/tpm2-tools that referenced this issue Nov 19, 2015
@flihp
build: Link against libtpm2tctisock.
01926dc 
This removes the immediate dependency on the socket TCTI sources
from the TPM2.0-TSS source tree resolving tpm2-software#6.

The code in the TPM2.0-TSS that this repo builds manually still
references this code (since it's local to that source tree) and
so these headers must remain in the C*FLAGS variable via -I. We
can't resolve this yet without sorting out an approach to tpm2-software#5.

Signed-off-by: Philip Tricca <philip.b.tricca@intel.com>
@flihp flihp mentioned this issue Nov 19, 2015
Merged
@gwei3 gwei3 closed this as completed in #9 Nov 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flihp flihp

Labels
bug
Projects
None yet
Milestone
packaging
Development

Successfully merging a pull request may close this issue.

Link against the socket TCTI and SAPI library. flihp/tpm2-tools
1 participant
@flihp