Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't halt upon error on a single gem #7

Merged
merged 1 commit into from
Sep 20, 2013
Merged

Don't halt upon error on a single gem #7

merged 1 commit into from
Sep 20, 2013

Conversation

ixti
Copy link
Contributor

@ixti ixti commented Sep 16, 2013

Gem backports has directory named tags. Thus gem ctags halts (and produces very cryptic error):

% gem ctags
Generating ctags for  abstract-1.0.0
Generating ctags for  actionmailer-3.0.20
Generating ctags for  actionpack-3.0.20
Generating ctags for  activemodel-3.0.20
Generating ctags for  activerecord-3.0.20
Generating ctags for  activeresource-3.0.20
Generating ctags for  activesupport-3.0.20
Generating ctags for  addressable-2.3.5
Generating ctags for  addressable-2.3.3
Generating ctags for  ansi-1.4.3
Generating ctags for  api_cache-0.2.3
Generating ctags for  arel-2.0.10
Generating ctags for  autoparse-0.3.3
Generating ctags for  awesome_print-1.1.0
ERROR:  While executing gem ... (Errno::EISDIR)
    Is a directory - tags

This patch does not halts, instead it just reports an error:

Failed processing ctags for backports-3.3.3:
  (Errno::EISDIR) Is a directory - tags
���```

@ixti
Copy link
Contributor Author

ixti commented Sep 16, 2013

Although my initial problem was kindly solved by @marcandre, I still think it's a good thing to not halt if errro happened in the middle. Or at least it should report which gem caused an error.

@bruno-
Copy link

bruno- commented Sep 18, 2013

Hi, the same error just happened to me and left me in a clueless state..
It would be great if this is fixed

Edit: I just checked and I also have an error with backports gem..

@ixti
Copy link
Contributor Author

ixti commented Sep 19, 2013

/cc @tpope can you please merge it or, I can update it to fit your requirements if something you don't like...

@tpope
Copy link
Owner

tpope commented Sep 19, 2013

Squash in a fix for the inadvertent whitespace change and I'll merge and cut a release. Thanks!

Gem [backports](https://github.com/marcandre/backports) had directory named
`tags`. Thus `gem ctags` halts (and produces very cryptic error):

```
% gem ctags
Generating ctags for  abstract-1.0.0
Generating ctags for  actionmailer-3.0.20
Generating ctags for  actionpack-3.0.20
Generating ctags for  activemodel-3.0.20
Generating ctags for  activerecord-3.0.20
Generating ctags for  activeresource-3.0.20
Generating ctags for  activesupport-3.0.20
Generating ctags for  addressable-2.3.5
Generating ctags for  addressable-2.3.3
Generating ctags for  ansi-1.4.3
Generating ctags for  api_cache-0.2.3
Generating ctags for  arel-2.0.10
Generating ctags for  autoparse-0.3.3
Generating ctags for  awesome_print-1.1.0
ERROR:  While executing gem ... (Errno::EISDIR)
    Is a directory - tags
```

This patch does not halts, instead it just reports an error:

```
Failed processing ctags for backports-3.3.3:
  (Errno::EISDIR) Is a directory - tags
```
@ixti
Copy link
Contributor Author

ixti commented Sep 19, 2013

@tpope Sorry about that whitespace mess (was using GH interface for editing). Now it's fixed.

tpope added a commit that referenced this pull request Sep 20, 2013
Don't halt upon error on a single gem
@tpope tpope merged commit 9341d8d into tpope:master Sep 20, 2013
@ixti
Copy link
Contributor Author

ixti commented Sep 20, 2013

Awesome! Thanks!

@ixti ixti deleted the patch-1 branch September 21, 2013 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants