Empty line and git syntax diff highlights

[Sangdol]

Hello Tim Pope,

First of all, thanks a lot for your contribution to this project and other vim plugins. You're making the world a better place.

I've noticed that the git and gitcommit syntax for gitDiffAdded and gitDiffRemoved don't work if an empty space is added in the code section, for example,

I looked into the git.vim syntax file and found out that it works if I make a small change in the gitDiff syntax by deleting the \!$ in the end condition like these:

" From
syn region gitDiff start=/^\%(diff --git \)\@=/ end=/^\%(diff --\|$\)\@=/ contains=@gitDiff fold
syn region gitDiff start=/^\%(@@ -\)\@=/ end=/^\%(diff --\%(git\|cc\|combined\) \|$\)\@=/ contains=@gitDiff

" To
syn region gitDiff start=/^\%(diff --git \)\@=/ end=/^\%(diff --\)\@=/ contains=@gitDiff fold
syn region gitDiff start=/^\%(@@ -\)\@=/ end=/^\%(diff --\%(git\|cc\|combined\) \)\@=/ contains=@gitDiff

After fixing the syntax:

I don't think this is the right way to fix this issue and am wondering if this is an issue only for me.

Could you explain why this is happening?

Thanks.

[tpope]

It deliberately terminates on a blank line because that's what separates it from the next commit in git log -p.