Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authorship #13

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Fix authorship #13

merged 1 commit into from
Jan 6, 2021

Conversation

lrq3000
Copy link
Member

@lrq3000 lrq3000 commented Jan 6, 2021

This PR fixes the authorship.

Interestingly, that's one of the instances showing the limitations of git-fame, since your first commit credited my original code as your contribution. No issue with that first commit, but that's why I chose to remove the git-fame percentages as they were misleading.

Other (non necessarily exhaustive) commits list of the genesis of py-make in chronological order:

BTW could you please give me back admin access to this repo? I would like to (somewhat) maintain it as I am still using it and see some parts that need improvements, and also some standing PRs. Thank you in advance @casperdcl !

Signed-off-by: Stephen L. <lrq3000@gmail.com>
@casperdcl casperdcl merged commit 01607d3 into tqdm:master Jan 6, 2021
@casperdcl
Copy link
Member

I wouldn't say this is a limitation of git or tools like git-fame, it's more of a problem when code is copy-pasted from a different repository to create a new project, it's not really possible to track original author stats line by line.

@lrq3000
Copy link
Member Author

lrq3000 commented Jan 13, 2021

Exactly, it's not an issue specific to git-fame but of any quantitative-only approach to contributions assessment. In this case you copied the code because you were the one to make it into a module (which was a great idea), so there was no way around, apart maybe from using some git magic to try to impersonate me, which would at best be a hack of git and would also be misleading as it would imply i committed in this repo directly which i did not at the time.

Thank you for merging this PR and trusting me with maintaining this repo, I'll take care of the PRs and some tidying soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants