Make spawning with memcache in rails 3.2.X work properly again - reset method on Rails.cache was not being defined #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reset method on Rails.cache was not being defined. We were seeing the classic connection sharing problems with memcache as Rails.cache.reset was not being called. It seems odd to check that the class has been autoloaded? At least in rails 3.2 when this gem is loaded, ActiveSupport::Cache is not autoloaded yet, hence the second condition is false. Remove that condition as it doesn't seem needed
tra
added a commit
that referenced
this pull request
Nov 19, 2013
Make spawning with memcache in rails 3.2.X work properly again - reset method on Rails.cache was not being defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing the classic connection sharing problems with memcache as Rails.cache.reset was not being called.
It seems odd to check that the class has been autoloaded?
At least in rails 3.2 when this gem is loaded, ActiveSupport::Cache is not autoloaded yet,
hence the second condition is false. Remove that condition as it doesn't seem needed