GOWIN algorithms re-write #371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aystarik
force-pushed
the
master
branch
3 times, most recently
from
55c08a8
to
45e8fb7
Compare
trabucayre
reviewed
Sep 2, 2023
Comment on lines
-748
to
-751
| #define spi_gowin_write(_wr, _rd, _len) do { \ | ||
| _jtag->shiftDR(_wr, _rd, _len); \ | ||
| _jtag->toggleClk(6); } while (0) | ||
|
|
There was a problem hiding this comment.
To avoid code duplication (for ease of maintenance/improvement) I prefer keeping this macro. After preprocessor pass code will look similar to your.
There was a problem hiding this comment.
It's better to make it a function then, "inline" was invented for this same purpose... Would you like what I update the patch?
aystarik
force-pushed
the
master
branch
4 times, most recently
from
469bfad
to
34aca16
Compare
Speed up toggleClk Defer write-only USB transactions to better utilize bus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checked working program SRAM, internal FLASH on Tang Nano1k and Tang Nano 9k with three JTAG cables: original FT232, on-board BL702 emulating FT2232 and CH347 (optimized in this PR).