Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action fails due to parsing error from LLM inaccurate polish response #77

Closed
h1alexbel opened this issue Apr 10, 2024 · 5 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@h1alexbel
Copy link
Contributor

Running polish goal
polish completed, response from gpt-4:
      {
    "Problems": [
        "The bug report does not clearly define the problem. It only suggests a solution without explaining the problem in any detail. It would be more helpful if it illustrated the exact issue occurring due to the \"explicit object copying\".",
        "The report does not include any steps to reproduce the bug. Providing steps to recreate the bug is a crucial part of a quality bug report.",
        "There are no logs, error messages, screenshots or any other evidence provided to support the claim made in the bug report."
    ]
}
...
Error: Cannot read properties of undefined (reading 'forEach')

As you can see polished response is in invalid format (typo Problems instead of problems). This resulting in thatmd-objects.ts can't parse input JSON. To handle this situation let's try to either try to analyze response in deterministic way and then parse/post the result (even if format is invalid) it or skip JSON package step by LLM, and work only with text.

@h1alexbel h1alexbel added the bug Something isn't working label Apr 10, 2024
Copy link

@h1alexbel thanks for the report, here is a feedback:

Problems:

  • The bug report does not clearly define the problem. It only suggests a solution without explaining the problem in any detail. It would be more helpful if it illustrated the exact issue occurring due to the 'explicit object copying'.
  • The report does not include any steps to reproduce the bug. Providing steps to recreate the bug is a crucial part of a quality bug report.
  • There are no logs, error messages, screenshots or any other evidence provided to support the claim made in the bug report.

Suggestions:

  • Clearly define the problem: - Please provide a detailed description of the issue, including a thorough explanation of the problematic behavior caused by the "explicit object copying." - Ensure that the problem statement is unambiguous and easy to understand.
  • Include steps to reproduce the bug: - Kindly detail the specific steps necessary to reproduce the bug. This will help in accurately identifying the issue and working towards a solution.
  • Provide supplementary evidence: - Attach any relevant logs, error messages, screenshots, or other supporting evidence that can aid in understanding and diagnosing the issue.
  • Correct the format of the response: - Modify the "Problems" key in the JSON response to match the correct format, i.e., "problems."
  • Handle the invalid JSON format: - Consider implementing a deterministic approach to parse the response, even if the format is invalid, and then parse/post the result. - Alternatively, modify the LLM process to work only with text and skip the JSON package step.

Please fix the bug report in order it to get resolved faster.
Analyzed with Phind/Phind-CodeLlama-34B-v2

@h1alexbel h1alexbel self-assigned this Apr 10, 2024
@h1alexbel
Copy link
Contributor Author

Let's try to summarize response in Markdown

h1alexbel pushed a commit that referenced this issue Apr 19, 2024
h1alexbel pushed a commit that referenced this issue Apr 19, 2024
h1alexbel pushed a commit that referenced this issue Apr 19, 2024
h1alexbel pushed a commit that referenced this issue Apr 19, 2024
h1alexbel pushed a commit that referenced this issue Apr 19, 2024
h1alexbel pushed a commit that referenced this issue Apr 19, 2024
h1alexbel pushed a commit that referenced this issue Apr 19, 2024
h1alexbel pushed a commit that referenced this issue Apr 19, 2024
h1alexbel pushed a commit that referenced this issue Apr 19, 2024
h1alexbel added a commit that referenced this issue Apr 19, 2024
feat(#77): markdown composition instead of json
@h1alexbel
Copy link
Contributor Author

@rultor release, tag is 0.3.2

@rultor
Copy link
Collaborator

rultor commented Apr 19, 2024

@rultor release, tag is 0.3.2

@h1alexbel OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Apr 19, 2024

@rultor release, tag is 0.3.2

@h1alexbel Done! FYI, the full log is here (took me 8min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants