Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TkGitHub: ProjectValidation, ErrorsCase #94

Merged
merged 3 commits into from
Jan 25, 2024
Merged

TkGitHub: ProjectValidation, ErrorsCase #94

merged 3 commits into from
Jan 25, 2024

Conversation

h1alexbel
Copy link
Contributor

@h1alexbel h1alexbel commented Jan 25, 2024

closes #69
closes #66


PR-Codex overview

This PR focuses on adding new functionalities and fixing formatting issues.

Detailed summary

  • Added id and name fields to no-arc.yml file
  • Added performers and roles in no-arc.yml file
  • Added @todo and @since annotations in XsApplied.java file
  • Added a new test case in GhIdentityTest.java file
  • Added new assertions in TkGitHubITCase.java file
  • Added license header in ProjectValidation.java file
  • Added new package and classes in tk and validation folders
  • Added test cases for new classes in ErrorsCaseTest.java and ProjectValidationTest.java files

The following files were skipped due to too many changes: src/test/java/git/tracehub/validation/ProjectValidationTest.java, src/main/java/git/tracehub/tk/TkGitHub.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@h1alexbel h1alexbel changed the title TkGitHub: ProjectValidation, ErrorsCase, TkGitHub: ProjectValidation, ErrorsCase Jan 25, 2024
@h1alexbel
Copy link
Contributor Author

@rultor merge

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (14aa5e6) 67.18% compared to head (d338460) 70.95%.
Report is 11 commits behind head on master.

Files Patch % Lines
src/main/java/git/tracehub/tk/TkGitHub.java 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #94      +/-   ##
============================================
+ Coverage     67.18%   70.95%   +3.77%     
- Complexity       81       87       +6     
============================================
  Files            29       31       +2     
  Lines           323      334      +11     
  Branches         19       19              
============================================
+ Hits            217      237      +20     
+ Misses           99       90       -9     
  Partials          7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rultor
Copy link
Collaborator

rultor commented Jan 25, 2024

@rultor merge

@h1alexbel Can't merge it. Some CI checks were failed. Apparently, the pull request is not ready to be merged since it has some problems. Please, fix them first.

@h1alexbel
Copy link
Contributor Author

For now tests for TkGitHub.java are disabled, lets try to resolve it ASAP; puzzle: #57

@h1alexbel h1alexbel merged commit dd08ef9 into master Jan 25, 2024
7 of 8 checks passed
@h1alexbel h1alexbel deleted the github-return branch January 25, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants