Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ONNX linear bug by not updating shape for linear if not present #1700

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

antimora
Copy link
Collaborator

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

#1560

Changes

Input shapes are not always present, so we skip updating the output if not known.

Testing

Tested on the user provided ONNX file in #1560

@antimora antimora added the bug Something isn't working label Apr 26, 2024
@antimora antimora requested a review from laggui April 26, 2024 19:28
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.51%. Comparing base (b387829) to head (1388afa).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/burn-import/src/onnx/dim_inference.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1700      +/-   ##
==========================================
- Coverage   86.51%   86.51%   -0.01%     
==========================================
  Files         696      696              
  Lines       81499    81498       -1     
==========================================
- Hits        70508    70506       -2     
- Misses      10991    10992       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antimora antimora merged commit 1cdceb5 into tracel-ai:main Apr 29, 2024
14 checks passed
@nathanielsimard nathanielsimard deleted the fix-gemm-to-linear-conversation branch April 29, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants