Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cube: first ported kernel + comptime support + variable reuse + cleanup #1797

Merged
merged 20 commits into from
May 22, 2024

Conversation

louisfd
Copy link
Member

@louisfd louisfd commented May 22, 2024

The convolution2d kernel has been ported to Cube

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 68.02974% with 172 lines in your changes are missing coverage. Please review.

Project coverage is 86.44%. Comparing base (76fe0ed) to head (d42426a).
Report is 7 commits behind head on main.

Files Patch % Lines
crates/burn-jit/src/kernel/conv/conv2d.rs 38.63% 81 Missing ⚠️
crates/burn-cube/src/language/comptime.rs 45.83% 13 Missing ⚠️
crates/burn-cube/tests/language/cast_elem.rs 45.45% 12 Missing ⚠️
crates/burn-cube/src/language/operation/binary.rs 0.00% 10 Missing ⚠️
crates/burn-cube/src/language/element/uint.rs 12.50% 7 Missing ⚠️
crates/burn-cube/tests/language/if.rs 0.00% 7 Missing ⚠️
crates/burn-cube/tests/language/if_else.rs 86.00% 7 Missing ⚠️
crates/burn-cube/src/language/branch.rs 86.66% 6 Missing ⚠️
...es/burn-cube/src/language/operation/assignation.rs 0.00% 6 Missing ⚠️
crates/burn-cube/src/language/element/numeric.rs 20.00% 4 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1797      +/-   ##
==========================================
+ Coverage   86.39%   86.44%   +0.04%     
==========================================
  Files         737      741       +4     
  Lines       85883    86114     +231     
==========================================
+ Hits        74202    74441     +239     
+ Misses      11681    11673       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@louisfd louisfd merged commit 0331719 into main May 22, 2024
15 checks passed
@louisfd louisfd deleted the feat/cube/convolution branch May 22, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants