Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cuda-jit #1799

Merged
merged 2 commits into from
May 24, 2024
Merged

Update cuda-jit #1799

merged 2 commits into from
May 24, 2024

Conversation

nathanielsimard
Copy link
Member

@nathanielsimard nathanielsimard commented May 22, 2024

  • Enables burn-cuda in the workspace, but isn't registered in burn-core, and therefore not available within the burn crate.
  • Enables burn-cuda in backend-comparison, to track the performance of the new runtime.
  • Remove automatic bound checks, since even if it fixes the correcness problems of the backend, it's increadibly slow. As we rewrite kernels with cubecl, we should do proper bound checking. When every kernel has been re-written, we will be able to deactivate automatic bound checking in wgpu as well (though it's more well done than our version with less branching).

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.44%. Comparing base (e39b4d2) to head (42e039e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1799   +/-   ##
=======================================
  Coverage   86.44%   86.44%           
=======================================
  Files         746      746           
  Lines       86121    86125    +4     
=======================================
+ Hits        74448    74452    +4     
  Misses      11673    11673           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanielsimard nathanielsimard merged commit c7ad25a into main May 24, 2024
15 checks passed
@nathanielsimard nathanielsimard deleted the fix/update-cuda-jit branch May 24, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants