Feat: Add movedim tensor operator
#1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
June 10, 2024 19:24
Introduce movedim function to allow dimension reordering in tensors. Enhance flexibility by supporting various argument types for dimension specification. Add necessary checks to validate dimensions.
…r consistency and simplify type handling
…ve insertion order lol
This reverts commit d2cf4e3.
…entation ✅ (movedim.rs): add test for out-of-bound axis on vec input
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1876 +/- ##
==========================================
- Coverage 86.28% 86.19% -0.10%
==========================================
Files 774 779 +5
Lines 90095 91179 +1084
==========================================
+ Hits 77740 78588 +848
- Misses 12355 12591 +236 ☔ View full report in Codecov by Sentry. |
LilDojd
commented
Jun 10, 2024
nathanielsimard
requested changes
Jun 13, 2024
…rray ♻️ (check.rs): remove hashbrown::HashSet dependency and replace with nested loops for duplicate check
|
Thanks for the review! I have addressed your comments in recent commit |
nathanielsimard
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks allscript has been executed.Related Issues/PRs
None
Changes
Added
movedimdefault implementation. Mirrors the PyTorch one.This just wraps a call to permute with sanity checks, but moving one/few axes while keeping all others inbound is a common enough operation to warrant its specific convenient syntactic sugar.
Testing
Added unit tests.