-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updated semantic conventions based on otel community #884
Conversation
Looks good! @gyliu513 |
@gyliu513 oh and one more thing - because of |
# Issue at https://github.com/open-telemetry/opentelemetry-python/issues/3868 | ||
# Refer to https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/llm-spans.md | ||
# for more detail for LLM spans from OpenTelemetry Community. | ||
LLM_SYSTEM = "gen_ai.system" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nirga do you think we need to change all of the key words from LLM_XX to GEN_AI_XXX?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm... don't think it's that important tbh
We'll switch to the "official" semantic convention constants when they'll be published
@nirga LoL, gonna reach out to you for some help, good to know this. Should be ready soon. do you think we need to change all of the key words from LLM_XX to GEN_AI_XXX? |
@nirga ready to go, can you help review and switch to the "official" semantic convention constants? Thanks! |
Done @gyliu513 |
Adopting open-telemetry/semantic-conventions#825
feat(instrumentation): ...
orfix(instrumentation): ...
.Fixed #880
@nirga ^^