Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated semantic conventions based on otel community #884

Merged
merged 6 commits into from Apr 29, 2024

Conversation

gyliu513
Copy link
Contributor

@gyliu513 gyliu513 commented Apr 23, 2024

Adopting open-telemetry/semantic-conventions#825

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

Fixed #880

@nirga ^^

@nirga
Copy link
Member

nirga commented Apr 23, 2024

Looks good! @gyliu513
You'll probably have some work updating the tests as well since many of them (🤦 ) aren't referencing the semconvs directly

@nirga nirga changed the title fix(semantic convention): Updated semantic conventio based on otel community fix(semantic convention): Updated semantic conventions based on otel community Apr 23, 2024
@gyliu513 gyliu513 changed the title fix(semantic convention): Updated semantic conventions based on otel community WIP fix(semantic convention): Updated semantic conventions based on otel community Apr 23, 2024
@nirga
Copy link
Member

nirga commented Apr 23, 2024

@gyliu513 oh and one more thing - because of poetry limitation, the ai-semantic-conventions package is always pulled from pypi. So I'll need to manually publish a version so that the build here will pass. Let me know when I can do that

# Issue at https://github.com/open-telemetry/opentelemetry-python/issues/3868
# Refer to https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/llm-spans.md
# for more detail for LLM spans from OpenTelemetry Community.
LLM_SYSTEM = "gen_ai.system"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirga do you think we need to change all of the key words from LLM_XX to GEN_AI_XXX?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... don't think it's that important tbh
We'll switch to the "official" semantic convention constants when they'll be published

@gyliu513
Copy link
Contributor Author

@gyliu513 oh and one more thing - because of poetry limitation, the ai-semantic-conventions package is always pulled from pypi. So I'll need to manually publish a version so that the build here will pass. Let me know when I can do that

@nirga LoL, gonna reach out to you for some help, good to know this. Should be ready soon. do you think we need to change all of the key words from LLM_XX to GEN_AI_XXX?

@gyliu513 gyliu513 changed the title WIP fix(semantic convention): Updated semantic conventions based on otel community fix(semantic convention): Updated semantic conventions based on otel community Apr 23, 2024
@gyliu513
Copy link
Contributor Author

@nirga ready to go, can you help review and switch to the "official" semantic convention constants? Thanks!

@nirga
Copy link
Member

nirga commented Apr 23, 2024

Done @gyliu513

@nirga nirga changed the title fix(semantic convention): Updated semantic conventions based on otel community feat: Updated semantic conventions based on otel community Apr 26, 2024
@nirga nirga merged commit 23eba2a into traceloop:main Apr 29, 2024
8 checks passed
@gyliu513 gyliu513 deleted the genai branch April 29, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Update semantic convention based on latest GenAI Semantion Convention
2 participants