Merge pull request #408 from locks/patch-1

Move Array#fill to "write then read" methods so the template correctly updates
tracked-tools · Sep 22, 2023 · 15c8ced · 15c8ced
2 parents 2a295d1 + 4c89ef3
commit 15c8ced
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/addon/src/-private/array.ts b/addon/src/-private/array.ts
@@ -18,7 +18,6 @@ const ARRAY_GETTER_METHODS = new Set<string | symbol | number>([
   'concat',
   'entries',
   'every',
-  'fill',
   'filter',
   'find',
   'findIndex',
@@ -41,6 +40,7 @@ const ARRAY_GETTER_METHODS = new Set<string | symbol | number>([
 // For these methods, `Array` itself immediately gets the `.length` to return
 // after invoking them.
 const ARRAY_WRITE_THEN_READ_METHODS = new Set<string | symbol>([
+  'fill',
   'push',
   'unshift',
 ]);

diff --git a/test-app/tests/unit/array-test.ts b/test-app/tests/unit/array-test.ts
@@ -14,7 +14,6 @@ const ARRAY_GETTER_METHODS = [
   'concat',
   'entries',
   'every',
-  'fill',
   'filter',
   'find',
   'findIndex',
@@ -36,6 +35,7 @@ const ARRAY_GETTER_METHODS = [
 
 const ARRAY_SETTER_METHODS = [
   'copyWithin',
+  'fill',
   'pop',
   'push',
   'reverse',