Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable clang format in files in the standalone/ directories #70

Conversation

slava77
Copy link

@slava77 slava77 commented Dec 21, 2021

this PR disables clang format in the standalone files.
This is somewhat temporary, until the migration and setup of the standalone builds inside cmssw repository is working.

This should let the cmssw tests PR going.

@makortel
please check and perhaps merge if the change looks reasonable

@makortel
Copy link
Collaborator

I sort of agree for the files that should eventually (before the PR into CMSSW gets merged) be removed (like from-root and nlohmann), but why not benefiting of consistent formatting for the standalone files that are intended to be kept? (not a big deal to me though)

@slava77
Copy link
Author

slava77 commented Dec 21, 2021

I sort of agree for the files that should eventually (before the PR into CMSSW gets merged) be removed (like from-root and nlohmann), but why not benefiting of consistent formatting for the standalone files that are intended to be kept? (not a big deal to me though)

there is #71 to remind about it.
I was not sure if there will be also steps of further moving or updating files in the standalone to make them compile or do cross-checks with the mkFit/devel etc. So, the idea was to minimize the changes for now (to just one line), until it's clear what will happen with the code in the standalone/.

@slava77 slava77 merged commit d86f680 into trackreco:mkFit-reincarnated Dec 22, 2021
@slava77
Copy link
Author

slava77 commented Dec 22, 2021

(not a big deal to me though)

I took the liberty to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants