Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge duplicate seeds #321

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Merge duplicate seeds #321

merged 2 commits into from
Jun 18, 2021

Conversation

osschar
Copy link
Collaborator

@osschar osschar commented Jun 14, 2021

Merge hits from cleaned duplicate seeds into the remaining seed.

This runs for --build-mimi and for CMSSW. It is not used for the legacy --build-bh/std/ce.

Statistics of merged seed hits: new stand alone files PU 50, 200 events:
http://xrd-cache-1.t2.ucsd.edu/matevz/PKF/SeedHitMerge/

Open question: Do we want to make this optional / add a configuration variable?

@areinsvo
Copy link
Collaborator

MTV plots here: http://uaf-10.t2.ucsd.edu/~lgiannini/plots_compareDupMergeSeeds_7iters
Standalone validation plots (without Matevz's fix of sorting the seeds, but since these results are all for build tracks, it shouldn't matter): https://areinsvo.web.cern.ch/areinsvo/MkFit/MultiIter/mergedDuplicates/
(Compare to the baseline here

I guess if we had a config variable for this, then it could be turned off for the strip-seeded variables? Otherwise, I don't see a need to make this optional.

Do we want to check timing before merging? I didn't run standalone benchmarks, but the MTV plots from @leonardogiannini have timing info (assuming all of those results were run on a mostly empty machine). The summary timing plot shows no change in build time but an increase in fit time.

@osschar
Copy link
Collaborator Author

osschar commented Jun 15, 2021

Seed cleaning is not run for all iterations ... when IterationConfig::m_require_quality_filter is true, it means we clean duplicates afterwards and do NOT do seed cleaning.

I wouldn't expect a significant impact on timing from this change.

@areinsvo areinsvo merged commit fcadb72 into devel Jun 18, 2021
@osschar osschar deleted the mergeDuplicateSeeds branch June 21, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants