Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Github actions setup correction (linting) #770

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

mfendeksilverstripe
Copy link
Contributor

@mfendeksilverstripe mfendeksilverstripe commented Jan 13, 2023

BUG: Github actions setup correction (linting)

  • linting setup corrected
  • fixed some linting errors
  • removed some unnecessary dist files

Follow up to #766

@mfendeksilverstripe mfendeksilverstripe marked this pull request as draft January 13, 2023 01:00
@mfendeksilverstripe mfendeksilverstripe changed the title BUG: JS Github action. BUG: Github actions setup correction (linting) Jan 13, 2023
@mfendeksilverstripe mfendeksilverstripe marked this pull request as ready for review January 13, 2023 02:22
Copy link

@blueo blueo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor comment on the sass lint from me :)

@@ -1,3 +1,4 @@
// sass-lint:disable no-important, class-name-format
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] consider disabling per line (eg // sass-lint:disable-line no-important) rather than the whole file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants