Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to disable crosshair #749

Closed
makedonsky94 opened this issue May 24, 2021 · 1 comment · Fixed by #1330
Closed

Add an option to disable crosshair #749

makedonsky94 opened this issue May 24, 2021 · 1 comment · Fixed by #1330
Labels
enhancement Feature requests, and general improvements. good first issue Good issue for first-time contributors. help wanted Asking for outside help and/or contributions to this particular issue or PR.

Comments

@makedonsky94
Copy link
Contributor

makedonsky94 commented May 24, 2021 •
edited by timocov
Loading

We need a flag or a method to hide the crosshair. Moreover this feature should disable long tap on canvas.

The case:

  • Make the crosshair invisible
  • Start the chart
  • Make a long tap on canvas
  • The chart looks like freezed
@makedonsky94 makedonsky94 changed the title Hide the crosshover Hide the crosshair May 24, 2021
@timocov timocov changed the title Hide the crosshair Add an option to disable crosshair May 24, 2021
@timocov timocov added enhancement Feature requests, and general improvements. good first issue Good issue for first-time contributors. help wanted Asking for outside help and/or contributions to this particular issue or PR. labels May 24, 2021
@timocov timocov mentioned this issue Jun 30, 2021
Open
@alekblom
Copy link

alekblom commented Apr 6, 2023 •
edited
Loading

Any news on this? Even though I am hiding crosshair (visually) on mobile, the chart script seems to think it exists, disabling panning around on the chart (occasionally) until i double touch the chart.

luk707 added a commit to luk707/lightweight-charts that referenced this issue Apr 7, 2023
@luk707
fix: Add an option to disable crosshair (tradingview#749)
513795e
luk707 added a commit to luk707/lightweight-charts that referenced this issue Apr 12, 2023
@luk707
fix: Add an option to disable crosshair (tradingview#749)
14747c4
@luk707 luk707 mentioned this issue Apr 12, 2023
Merged
6 tasks
SlicedSilver added a commit that referenced this issue Sep 26, 2023
@SlicedSilver
Merge pull request #1330 from luk707/master
8311bfc 
fix: Add an option to disable crosshair (#749)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature requests, and general improvements. good first issue Good issue for first-time contributors. help wanted Asking for outside help and/or contributions to this particular issue or PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add an option to disable crosshair (#749) luk707/lightweight-charts
3 participants
@timocov @makedonsky94 @alekblom