Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a11y tutorial #1453

Merged
merged 4 commits into from
Nov 29, 2023
Merged

add a11y tutorial #1453

merged 4 commits into from
Nov 29, 2023

Conversation

SlicedSilver
Copy link
Contributor

Type of PR: Adding a new tutorial to documentation site

PR checklist:

  • Documentation update

Overview of change:
Adds a tutorial for improving A11y on a simple LWC chart.

Preview: https://luxury-marshmallow-ad795c.netlify.app/lightweight-charts/tutorials

@SlicedSilver SlicedSilver added the documentation Improvements or additions to the documentation label Nov 6, 2023
@SlicedSilver SlicedSilver self-assigned this Nov 6, 2023
website/tutorials/a11y/intro.mdx Outdated Show resolved Hide resolved
website/tutorials/a11y/keyboard.mdx Outdated Show resolved Hide resolved
website/tutorials/a11y/keyboard.mdx Outdated Show resolved Hide resolved
website/tutorials/a11y/keyboard.mdx Outdated Show resolved Hide resolved
website/tutorials/a11y/keyboard.mdx Outdated Show resolved Hide resolved
website/tutorials/a11y/readability.mdx Outdated Show resolved Hide resolved
website/tutorials/a11y/readability.mdx Outdated Show resolved Hide resolved
website/tutorials/a11y/readability.mdx Outdated Show resolved Hide resolved
website/tutorials/a11y/readability.mdx Outdated Show resolved Hide resolved
website/tutorials/a11y/readability.mdx Outdated Show resolved Hide resolved
@anachuprina
Copy link
Contributor

Minor:

  • Inconsistent headings style (sentence case & title case)
  • Inconsistent use of the words: JS/JavaScript
  • The wording and grammar used in the conclusion are a bit complicated

@SlicedSilver SlicedSilver merged commit 635baa2 into master Nov 29, 2023
22 checks passed
@SlicedSilver SlicedSilver deleted the a11y-tutorial branch November 29, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants