Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: migrate to github-actions-storybook-to-github-pages #434

Merged
merged 2 commits into from
Jul 9, 2024
Merged

ci: migrate to github-actions-storybook-to-github-pages #434

merged 2 commits into from
Jul 9, 2024

Conversation

mdeliatf
Copy link
Contributor

@mdeliatf mdeliatf commented Jul 8, 2024 •
edited
Loading

Description

  • Replace storybook-deployer, that is deprecated, with github-actions-storybook-to-github-pages
  • Prevent Deploy and Release workflows to run in forks

Fixes #428

Preview

No visual changes.

Dependency changes

Dependency Version State
@storybook/storybook-deployer ^2.8.16 Removed

Good PR checkboxes

  • Change has been tested
  • Added/Updated tests
  • Added/Updated stories
  • PR follows conventions
  • Labels are set
  • Project is linked

Good Review checkboxes

ℹ️ Copy the snippet and paste in the review field to fill it 
- [ ] I've tested the changes
- [ ] I've agreed on the unit tests (soon to come)
- [ ] I've checked the stories
- [ ] I've read the code and understood it
- [ ] I don't have any more questions
- [ ] I've described any optional improvements
- [ ] I checked PR follows [conventions](https://github.com/traefik/faency#how-to-contribute)

@mdeliatf mdeliatf self-assigned this Jul 8, 2024
@mdeliatf mdeliatf marked this pull request as ready for review July 8, 2024 13:54
@mdeliatf mdeliatf marked this pull request as draft July 9, 2024 13:19
@mdeliatf mdeliatf force-pushed the ci/migrate-to-github-actions-storybook-to-github-pages branch 2 times, most recently from 7c96470 to 6bbb822 Compare July 9, 2024 14:03
@mdeliatf mdeliatf marked this pull request as ready for review July 9, 2024 14:04
@mdeliatf mdeliatf force-pushed the ci/migrate-to-github-actions-storybook-to-github-pages branch from 6bbb822 to 834472d Compare July 9, 2024 14:05
@mdeliatf mdeliatf force-pushed the ci/migrate-to-github-actions-storybook-to-github-pages branch from 834472d to aafac72 Compare July 9, 2024 14:12
@mdeliatf mdeliatf requested a review from gndz07 July 9, 2024 14:12
@traefiker traefiker merged commit 5ed9732 into traefik:master Jul 9, 2024
3 checks passed
@traefiker
Copy link
Contributor

🎉 This PR is included in version 10.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gndz07 gndz07 gndz07 approved these changes

Assignees

@mdeliatf mdeliatf

Labels
kind/bug/fix a bug fix released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Infra] Replace storybook-deployer with github-actions-storybook-to-github-pages
3 participants
@mdeliatf @traefiker @gndz07