Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing Implementation #63

Closed
dtomcej opened this issue Jun 18, 2019 · 6 comments
Closed

Tracing Implementation #63

dtomcej opened this issue Jun 18, 2019 · 6 comments

Comments

@dtomcej
Copy link
Contributor

dtomcej commented Jun 18, 2019

How did we want to implement tracing?

Not sure how tracing is implemented in Traefik v2

@dtomcej
Copy link
Contributor Author

dtomcej commented Jun 19, 2019

Tracing is global config in v2.

This is prime candidate for feature dev. We can add this config into the helm chart, and have traefik do all the heavy lifting!

@dtomcej
Copy link
Contributor Author

dtomcej commented Jun 20, 2019

@SantoDE What did you think about configuring tracing? Did we want to do something like the current traefik helm chart for tracing?

tracing.enabled, tracing.jaeger.localAgentHostPort that sort of thing?

It might be nice to have consistency, and its not a bad way of organizing it?

@mmatur did you have any recommendations/suggestions?

@mmatur
Copy link
Member

mmatur commented Jun 21, 2019

@dtomcej during my research about competitors I can see that all of major competitors install by default prometheus, grafana and jaeger. And the mesh is configure automatically by default.

But yeah we need to be able to customize these settings. If we want to propose a helm chart installation we have to as closer as we can of traefik helm configuration.

@SantoDE
Copy link

SantoDE commented Jun 21, 2019

Yeah, I agree. Most competitors just do all of that by default. I really like the idea to have it customizable tough. It just gives you more control about your desired state.

@dtomcej
Copy link
Contributor Author

dtomcej commented Jun 21, 2019

Ok, I will open tickets to implement those into the helm chart!

@mmatur
Copy link
Member

mmatur commented Jun 24, 2019

Closed by #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants