Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: build in docker #11

Merged
merged 2 commits into from
Jun 10, 2019
Merged

feat: build in docker #11

merged 2 commits into from
Jun 10, 2019

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Jun 7, 2019

Description

This PR:

  • use cobra for command line
  • create a version command
  • build in a docker container

@mmatur mmatur requested a review from dtomcej June 7, 2019 18:20
dtomcej
dtomcej suggested changes Jun 7, 2019
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@mmatur @dtomcej
Update Makefile
ca98eee 
Co-Authored-By: Daniel Tomcej <daniel.tomcej@gmail.com>
dtomcej
dtomcej approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@dtomcej dtomcej merged commit 966c271 into traefik:master Jun 10, 2019
@dtomcej dtomcej mentioned this pull request Jun 10, 2019
Closed
8 tasks
@mmatur mmatur deleted the feature/ci-integration branch June 11, 2019 06:49
@mmatur mmatur added this to the v0.1.0 milestone Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmatur @dtomcej