Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ACL example #780

Merged
merged 1 commit into from
Nov 14, 2020
Merged

Fix ACL example #780

merged 1 commit into from
Nov 14, 2020

Conversation

yekangming
Copy link
Contributor

What does this PR do?

  • This PR this fixed documentation about ACL example

  • Port changed from string to number

Fixes #778

How to test it

  • make test

  • make test-integration

@yekangming
Fix ACL example
06d1741 
Port changed from string to number
@kevinpollet kevinpollet added this to the v1.4 milestone Nov 14, 2020
@kevinpollet kevinpollet self-requested a review November 14, 2020 13:22
kevinpollet
kevinpollet approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@traefiker traefiker merged commit beb66a7 into traefik:v1.4 Nov 14, 2020
@traefiker traefiker mentioned this pull request Nov 14, 2020
Closed
@yekangming yekangming deleted the issue-778-fix-ACL-examples branch November 16, 2020 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpollet kevinpollet kevinpollet approved these changes

Assignees
No one assigned
Labels
area/documentation area/smi kind/bug/fix a bug fix
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@yekangming @kevinpollet @traefiker