Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load .env file during documentation build with a docker image #11

Merged
merged 2 commits into from
Jul 9, 2019
Merged

Load .env file during documentation build with a docker image #11

merged 2 commits into from
Jul 9, 2019

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Jul 9, 2019

Description

This PR allow structor to use .env file during the documentation build.

This also remove the environment variable substitution from structor and let mkdocs to do it.

@mmatur mmatur added the kind/enhancement New feature or request label Jul 9, 2019
@mmatur mmatur requested a review from ldez July 9, 2019 13:01
ldez
ldez approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 0482595 into master Jul 9, 2019
@ldez ldez deleted the feature/docker-env-file branch July 9, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmatur @ldez