feat: add support for privileged ports usage without root user #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloiseleur
changed the title
mloiseleur
changed the title
ldez
changed the title
mpl
previously approved these changes
Oct 7, 2022
|
@mloiseleur what's the difference between doing a setcap directly on the binary, and running the container with --cap-add=NET_BIND_SERVICE ? |
|
@mpl That's correct. It's clearly better to provide it with the I'll close this PR then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user wants to run
traefikdocker image without being root, he cannot listen on ports < 1024 by default. The binary needs a special capability in order for him to do so.This PR add this capability to
traefikbinary, since Traefik is expected to listen on ports like 443 or 80.UPDATE: It seems recent version of Docker removes the needs of this capability cf this commit.
Supersedes #18
Fixes #7
Additional Informations
Co-authored-by: Samuel MARTIN MORO faust64@gmail.com
Co-authored-by: Mandus Momberg git@momberg.me