Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some typos in comments #10626

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Fix some typos in comments #10626

merged 1 commit into from
Apr 18, 2024

Conversation

hidewrong
Copy link
Contributor

What does this PR do?

fix some typos in comments

Motivation

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

juliens
juliens approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinpollet kevinpollet self-requested a review April 18, 2024 12:19
@hidewrong @kevinpollet
chore: fix some typos in comments
b296d50 
Signed-off-by: hidewrong <hidewrong@outlook.com>
@kevinpollet kevinpollet changed the base branch from master to v3.0 April 18, 2024 13:00
@kevinpollet kevinpollet changed the title chore: fix some typos in comments Fix some typos in comments Apr 18, 2024
kevinpollet
kevinpollet approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@kevinpollet kevinpollet added this to the 3.0 milestone Apr 18, 2024
rtribotte
rtribotte approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@traefiker traefiker merged commit 7b649e2 into traefik:v3.0 Apr 18, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtribotte rtribotte rtribotte approved these changes

@kevinpollet kevinpollet kevinpollet approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/documentation kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@hidewrong @juliens @kevinpollet @rtribotte @traefiker