Remove config reload failure metrics #9660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtribotte
added
status/2-needs-review
kind/bug/fix
traefiker
force-pushed
the
remove-config-reload-failure-metrics
branch
from
6186203
to
c3bc3b9
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the configuration reload failure metrics.
Motivation
As of today, there is no mechanism or way to identify a configuration reload failure, and this is why the metric has never been implemented in Traefik v2.
Targeting v3, we can move forward and drop the metric until it can really be implemented.
Fixes #7471
More
Additional Notes
There are no changes in the documentation because those metrics were not documented.