add hotkeys for unslecting and deleting timespans #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmattheis
requested changes
Oct 22, 2023
jmattheis
approved these changes
Oct 23, 2023
CalebBassham
added a commit
to CalebBassham/traggo-server
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added hotkeys for deleting timespans.
Selecting a timespan and pressing delete or backspace will delete it.
Pressing escape will unselect.
Pressing escape after creating a new timespan will delete the newly created timespan until it or another timespan has been selected. Side note: I think it would be preferred to set newly created timespans as selected and open the popper menu for tagging and whatnot and this side case would no longer be necessary as just pressing delete and backspace / the trash icon would feel more natural. But... I can't figure out how to get that to work and without it, this feels pretty good.