Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to optionally show "Total" in most dashboard entry types #89

Merged
merged 6 commits into from
Nov 3, 2024

Conversation

hulmgulm
Copy link
Contributor

This is my first attempt to implement #88

The Dashboard Entry Editor allows to choose Total Hidden/Visible for all table types:
image
image

Sample dashboard:
image

@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.62%. Comparing base (a591539) to head (b0d0beb).
Report is 17 commits behind head on master.

❗ Current head b0d0beb differs from pull request most recent head 6cbc4ef. Consider uploading reports for the commit 6cbc4ef to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   92.57%   92.62%   +0.05%     
==========================================
  Files          70       70              
  Lines        1549     1533      -16     
==========================================
- Hits         1434     1420      -14     
+ Misses         80       79       -1     
+ Partials       35       34       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hulmgulm
Copy link
Contributor Author

Small UI change. This looks better:
image

@hulmgulm
Copy link
Contributor Author

Added total to line and bar chart tool tips:
image

Different label for switch depending on entry type:
image
image
image

@hulmgulm hulmgulm changed the title Allow to show "Total" in dashboard entries of type "Table" Allow to optionally show "Total" in most dashboard entry types Feb 27, 2021
Copy link
Contributor

@sdykae sdykae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine @jmattheis @simhnna

Copy link
Contributor

@sdykae sdykae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤏😏

@ericu109
Copy link

Having this as an option would be great for my use case, as I'm currently using Traggo to track billable hours on consulting projects. I often wonder the total time logged for the day against different projects, and I pretty much never have more than one entry going at the same time.

@eitch
Copy link

eitch commented Jan 3, 2023

Hi guys, what is the status of this PR? I would like this feature too

@jmattheis
Copy link
Member

@eitch see #88

@alonsomoya
Copy link

I would love having this feature released

@maximecurioni
Copy link

maximecurioni commented Jul 12, 2023

+1

I look at my Traggo dashboard 10x a day with daily, weekly and monthly hours broken down by client, and I'd love to have the total automatically computed for me, rather than doing it in my head 😄

@Minnowo
Copy link
Contributor

Minnowo commented Sep 21, 2024

Is this waiting on anything? I pulled the code and everything looks good.

@eitch
Copy link

eitch commented Oct 28, 2024

@hulmgulm Do you perhaps push this to a docker registry for use?

@hulmgulm
Copy link
Contributor Author

This feature is ready to be merged for a long time now and many people are asking for it. I don't want to create a fork of Traggo. @jmattheis @simhnna, what do I need to do get this PR merged?

@jmattheis
Copy link
Member

@hulmgulm Yeah, you're right. I'll try to review the PR this week and then create a release for it.

Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I've made some small changes (see fixups)

  • add default:false for total sql field
  • refactor the summing of the time spans to use reduce
  • move the getTotalTitle method

@jmattheis jmattheis merged commit a87b588 into traggo:master Nov 3, 2024
1 check passed
@hulmgulm
Copy link
Contributor Author

hulmgulm commented Nov 3, 2024

Vielen Dank Jannis!

@sdykae
Copy link
Contributor

sdykae commented Nov 3, 2024

@jmattheis congrats, took years but finally 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants