Support for Ubuntu network-manager VPN connections #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's add this to the new ciphers branch. Instead of "windows" we can call it "compatible". Then "compatible" can support both Windows and Ubuntu w/ Network Manager. IMHO go for aes128, the extra headroom up to 256 is worthless. |
|
Sounds good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do we want to make yet another condition for cipher selection for Ubuntu or just support this unconditionally? I've just added it to the cipher list for now.
Looks like libcharon doesn't enable any AES GCM ciphers by default and opts to enable Camellia CCM ciphers instead (export restrictions? idk).
See #263