Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --pipe-stderr and --pipe-stdout flags #822

Merged
merged 12 commits into from
Sep 6, 2023

Conversation

faculerena
Copy link
Contributor

We are using dylint in our project Scout and added the flags --pipe-stderr and --pipe-stdout in order to manually capture the output, allowing for later processing, both from the CLI and when using the Dylint crate. We'd appreciate if you accept the change. Great work on Dylint!.

@CLAassistant
Copy link

CLAassistant commented Sep 4, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@smoelius smoelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the number of requested changes. Hopefully, they all make sense.

I will be happy to merge once these minor points are addressed.

cargo-dylint/src/main.rs Outdated Show resolved Hide resolved
cargo-dylint/src/main.rs Outdated Show resolved Hide resolved
cargo-dylint/src/main.rs Outdated Show resolved Hide resolved
dylint/src/lib.rs Outdated Show resolved Hide resolved
dylint/src/lib.rs Outdated Show resolved Hide resolved
dylint/src/lib.rs Outdated Show resolved Hide resolved
dylint/src/lib.rs Outdated Show resolved Hide resolved
dylint/src/lib.rs Outdated Show resolved Hide resolved
cargo-dylint/src/main.rs Outdated Show resolved Hide resolved
cargo-dylint/src/main.rs Outdated Show resolved Hide resolved
@faculerena
Copy link
Contributor Author

Valid changes, done and pushed. Also, if you merge it, do you know when the next release will drop? In the meantime, we are working with the fork so no worries!
Thanks for the review and the project!

@faculerena
Copy link
Contributor Author

faculerena commented Sep 5, 2023

The "CI/ test (windows-latest, examples) is failing but I don't think it's related to this modifications, as I'm not using windows nor winapi. Do you know where could it be failing?

  -error: multiple versions for dependency `winapi`: 0.2.8, 0.3.9
  +error: could not read cargo metadata: `cargo metadata` exited with an error: error: failed to download `winapi v0.2.8`
  +       
  +       Caused by:
  +         unable to get packages from source
  +       
  +       Caused by:
  +         failed to download replaced source registry `crates-io`
  +       
  +       Caused by:
  +         failed to unpack package `winapi v0.2.8`
  +       
  +       Caused by:
  +         failed to remove directory `C:/Users/runneradmin/.cargo/registry/src/index.crates.io-6f17d22bba15001f/winapi-0.2.8`
  +       
  +         Caused by:
  +             The process cannot access the file because it is being used by another process. (os error 32)
  +       
  +         Error: failed to remove directory `C:/Users/runneradmin/.cargo/registry/src/index.crates.io-6f17d22bba15001f/winapi-0.2.8`
  +       
  +       Caused by:
  +         The process cannot access the file because it is being used by another process. (os error 32)
     |
     = note: `-D clippy::multiple-crate-versions` implied by `-D warnings`
   
   error: could not compile `multiple_crate_versions` (bin "multiple_crate_versions") due to previous error

@smoelius
Copy link
Collaborator

smoelius commented Sep 6, 2023

It looks like the failure was sporadic.

I will publish a new version before the end of the week.

Thanks very much for your contribution!

@smoelius smoelius added this pull request to the merge queue Sep 6, 2023
Merged via the queue into trailofbits:master with commit 521c44a Sep 6, 2023
13 checks passed
@smoelius
Copy link
Collaborator

smoelius commented Sep 7, 2023

This was released in version 2.3.0. Please let me know if it doesn't work as you expect.

@faculerena
Copy link
Contributor Author

Works perfect, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants