Handle the new pt_regs syscall convention #80
Assignees
Labels
Comments
woodruffw
added a commit
that referenced
this issue
Dec 24, 2019
See #80: Ubuntu 18.04 on GitHub Actions appears to use the HWE kernel, which uses a new syscall parameter convention that we don't support yet.
woodruffw
added a commit
that referenced
this issue
Dec 26, 2019
Handles pt_regs-based syscalls. Closes #80.
woodruffw
added a commit
that referenced
this issue
Dec 26, 2019
* module: Syscall wrapper codegen Handles pt_regs-based syscalls. Closes #80. * ci: Enable ubuntu-latest builds These should work now. * module/codegen: Minimize special-casing The pt_regs handling is a superset of the original handling, so just use it everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of Linux 4.17, x86_64 kernels built with
CONFIG_ARCH_HAS_SYSCALL_WRAPPER=yno longer use the userspace parameter list for syscalls, but instead use a singlept_regs*argument which they unpack internally.As part of these changes, the
sys_*prototypes are no longer exposed directly on x86_64 vialinux/syscalls.h. This requires us to make some codegen changes:"#{ASMLINKAGE} #{TYPEOF}(sys_#{call}) krf_sys_#{call};"and similar should become something like:
"#{ASMLINKAGE} #{SYSCALL_RET_TYPE} (*krf_sys_#{call})(pt_regs*);"We should be able to handle this difference conditionally by checking the running kernel config, e.g. via
/lib/modules/$(uname -r)/build/.config. This requires additional codegen cruft, which indicates that it's maybe finally time to split FreeBSD's codegen out from Linux's.The text was updated successfully, but these errors were encountered: