-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LD_LIBRARY_PATH type feature #878
Conversation
Use of environment variable MANTICORE_LD_PATH instead of LD_LIBRARY_PATH which is protected on MacOS Fixes trailofbits#93
Better than #861 for handling interpreter error |
Please use |
manticore/platforms/linux.py
Outdated
interpreter = ELFFile(file(interpreter_filename)) | ||
elif 'MANTICORE_LD_PATH' in os.environ: | ||
for mpath in os.environ['MANTICORE_LD_PATH'].split(":"): | ||
logger.info("looking for interpreter %s", mpath+'/'+os.path.basename(interpreter_filename)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use os.path.join
to concatenate paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also use a variable for the interpreter path.
Commit to be squashed afterwards
Thanks @disconnect3d |
Thanks again @catenacyber. I am thinking of what the best way to incorporate changes from this. I have a few concerns:
|
Ok, so I need to convert MANTICORE_LD_PATH environment variable to argument ld_path.
@yan I am not sure what you mean. |
What I meant was setting What I meant above is, currently |
The point of this pull request is to progress towards macOS support
The latter looks the best option to me. |
@catenacyber The latter choice sounds reasonable to me as well. So this would include passing |
thanks @yan you were faster than me But there is a typo with one variable name interpreter_path_filename |
Use of environment variable MANTICORE_LD_PATH
instead of LD_LIBRARY_PATH which is protected on MacOS
Fixes #93
This change is