Henrik/section #6500
Merged
Henrik/section #6500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still very rough and with old/new code mixed. Highlights the main ideas of the section based approach. Test cases for tdag c++ impl won't run due to build problems.
This section will be used as an index for which taint labels are source taint. Future use might include the affects control flow marker.
First one is omitting the last source file byte from cavity range. Second one is attempting to read the same file content multiple times, resulting in printing empty strings.
…or TDProgramTrace
Record the size of files used as taint sources when possible. Fallback handling in analysis when not possible.
surovic
force-pushed
the
Henrik/section
branch
from
64e8423
to
a01920e
Compare
surovic
force-pushed
the
Henrik/section
branch
from
c7dbfad
to
cdbae2b
Compare
surovic
suggested changes
Nov 15, 2022
| @@ -73,49 +73,71 @@ def marker_to_ranges(self, m: bytearray) -> List[CavityType]: | |||
| ranges.append((start, i)) | |||
| start = None | |||
| if start is not None: | |||
| ranges.append((start, len(m) - 1)) | |||
| ranges.append((start, len(m))) | |||
| return ranges | |||
|
|
|||
| def file_cavities(self) -> Dict[Path, List[CavityType]]: | |||
There was a problem hiding this comment.
Was this tested for equivalent performance? We had issues with improperly implemented DFS traversals before.
There was a problem hiding this comment.
Will look into the DFS performance. I don't think there should be much difference, but you never know. Good point!
There was a problem hiding this comment.
@surovic I believe we can resolve this after our discussion, right?
The same DFS is used as previously. Also a bug was uncovered and is solved by this new implementation. We would incorrectly mark source offsets as used in case of multiple source files. Have probably not been a problem in practice though.
surovic
suggested changes
Nov 15, 2022
surovic
suggested changes
Nov 18, 2022
surovic
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated section PR. Rewrite of the tdag output file handling to a more structured section-based approach.