Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make prop-types declaration file a dependency #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thchia
Copy link

@thchia thchia commented Apr 3, 2018

Description

Moved @types/prop-types from devDependencies to dependencies.

Addressed issue #15

TypeScript consumers of the library need this package due to the type export in utils.d.ts. Currently as it is a devDependency it is not included in a normal install and results in TS compiler errors.

I have followed the official suggestion here of including it as a regular dependency.

Our package exposes declarations from each of those, so any user of our [browserify-typescript-extension - react-skeletor] package needs to have these dependencies as well. For that reason, we used "dependencies" and not "devDependencies", because otherwise our consumers would have needed to manually install those packages.

@alex3165
Copy link
Contributor

alex3165 commented Apr 16, 2018

@thchia Thanks for the PR, can you also move @types/react, the same should apply to this dependency then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants