-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve scrobbling issues with new Plex Scanner/Agent #616
base: master
Are you sure you want to change the base?
Conversation
… try and resolve multi-part scrobbling issues
… can include the show id's and the correct year
@Cornishman thanks for looking into the issue! I am still receiving the following error when playing a movie:
|
@disrupted Sorry about that, this was spotted by another user as well. - I failed to commit a change 😞 |
@Cornishman it's working now, great job! |
How can I test this change @disrupted @Cornishman? Edit: Nevermind, figured it out, it is working, thank you so much! |
Any indication on when we can expect these changes to land? 👀 |
Just wanted to thank you @Cornishman for keeping this alive! Works like a charm |
@razzeee for visibility 👀 |
Tested on my machine, works perfectly - thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested replacing the 7 modified files here over my https://github.com/trakt/Plex-Trakt-Scrobbler folder and fixed my issues. Thanks!
@Cornishman thanks to your contribution the plugin shows up in the plugin list.
|
@KillrOfLife you need this pull request as well as #615 to make the plugin work again. Make sure your config is up-to-date at https://trakt-for-plex.github.io/configuration if you're "using the API" in the plugin. |
This should resolve new issues with scrobbling with the new Plex Scanner/Agent metadata.
Scrobbling should now correctly send the Show external
ids
to Trakt to ensure scrobble matches are more accurate.This should also resolve some scenarios where multi-part episodes were not scrobbling correctly.
Scrobbling data sent to Trakt should now look like more akin to this:
Fixes #596
Fixes #598
Fixes #605