Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for instances ids #180

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Add support for instances ids #180

merged 3 commits into from
Jan 2, 2024

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Dec 30, 2023

No description provided.

@gsheni gsheni self-assigned this Dec 30, 2023
Copy link

codecov bot commented Dec 30, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (41539cb) 84.38% compared to head (21766df) 84.53%.

Files Patch % Lines
trane/core/utils.py 71.42% 2 Missing ⚠️
trane/core/problem.py 66.66% 1 Missing ⚠️
trane/parsing/denormalize.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   84.38%   84.53%   +0.15%     
==========================================
  Files          29       29              
  Lines        1377     1384       +7     
==========================================
+ Hits         1162     1170       +8     
+ Misses        215      214       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gsheni gsheni marked this pull request as ready for review December 30, 2023 14:45
@gsheni gsheni merged commit ed6a3ca into main Jan 2, 2024
12 of 13 checks passed
@gsheni gsheni deleted the updates_2 branch January 2, 2024 15:45
@gsheni gsheni mentioned this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant