Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional unit tests for _check_operations_valid #93

Merged
merged 7 commits into from
Jul 8, 2023

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Jul 8, 2023

@gsheni gsheni self-assigned this Jul 8, 2023
@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.18 ⚠️

Comparison is base (96ee9c2) 87.97% compared to head (af29f01) 87.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   87.97%   87.79%   -0.18%     
==========================================
  Files          24       24              
  Lines         790      795       +5     
==========================================
+ Hits          695      698       +3     
- Misses         95       97       +2     
Impacted Files Coverage Δ
trane/typing/inference_functions.py 80.15% <ø> (ø)
trane/core/prediction_problem_generator.py 93.45% <71.42%> (-1.69%) ⬇️
trane/typing/inference.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gsheni gsheni merged commit 9a86f64 into main Jul 8, 2023
@gsheni gsheni deleted the make_meta_optional branch July 8, 2023 21:38
@gsheni gsheni mentioned this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional unit tests for _check_operations_valid
1 participant