-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add filter flag to allow generating configs for subset of folders #124
Conversation
I was originally using the root flag for this but realized this caused unintended issues with Atlantis and how the pattern matching is done. This provides an additional flag "--filter" that is passed to FindConfigFilesInPath() to only search a sub-path based on root. See runatlantis/atlantis#1466
Looks like the feature will need a bit more work after adding tests. They are currently failing with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two new tests are failing, which I believe to be because some of these functions require absolute paths passed in, while the filterPath
specified in the tests is relative.
I added a suggestion for where I believe the filepath.Abs
call ought to go, please let me know if you have other suggestions.
Thank you very much for this wonderful PR with great comments and tests, I will merge and release as soon as tests pass
Co-authored-by: David Mattia <david@transcend.io>
@dmattia Ah! Make sense! I don't have any other suggestions at this time. The tests pass locally with your suggestion. Thank you for a wonderful tool. I appreciate your kind words. :) |
Pull Request
Related Github Issues
Description
I was originally using the root flag for this but realized this caused
unintended issues with Atlantis and how the pattern matching is done.
This provides an additional flag "--filter" that is passed to
FindConfigFilesInPath() to only search a sub-path based on root.
Security Implications
System Availability