Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piotrkala/sc 55961/do not generate atlantis yaml if no paths #275

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kalapiotr
Copy link

Pull Request

Description

Currently if no paths match glob passed in --filter atlantis.yaml is still generated and then atlantis plan is executed for all paths. We want to exit early and do NOT generate atlantis.yaml file if no paths match filter to avoid executing atlantis plan for all files

version 1.16.1

I did not want to produce 1.16.2 version since we would have to produce an entire new docker image that points to that version. I think this is still in development/experimental phase and staying with 1.16.1 is good enough for now

Tests

Tested locally:

➜  terragrunt-atlantis-config git:(piotrkala/sc-55961/do-not-generate-atlantis-yaml-if-no-paths) ~/terragrunt-atlantis-config_1.16.2_linux_amd64/terragrunt-atlantis-config_1.16.2_linux_amd64 generate --output atlantis.yaml --autoplan --filter 'src/**/dev/**' --parallel=false
INFO[0000] Could not find an old config file. Starting from scratch 
INFO[0000] No paths found for glob patter: src/**/dev/** 

NO atlantis.yaml file was generated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant