B-19935

[CoryKleinjanCACI]

19935

Integration Review

Summary

This task is to remove unused columns from the ppm_shipments table. The move_to_gbloc view also looked at the pickup_post_code column so that had to be updated to use the new address fields.

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

Customer PPM Tests:

1. Access the application as a customer
2. Create a new move
3. Create a new PPM Shipment for the move
4. Finalize the shipment
5. Finish and sign the move

SC Office PPM Tests:

1. Access the application
2. Sign is as a service counselor
3. Find the move you created
4. Approve the PPM you created
5. Submit move details

TOO Office PPM Tests:

1. Sign into the application
2. Sign in as a TOO
3. Find the move you created
4. Edit the ppm details to ensure updating works

Prime PPM Tests: ( I used move code: 648TQB. Some of the moves don't have fully populated test data and don't work for some functions)

1. Access the application Prime Simulator
2. Open a move
3. Create a new PPM Shipment
4. Edit the PPM Shipment
5. Delete the PPM Shipment

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots

[github-actions]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[github-actions]

This PR was closed because it has been stalled for 10 days with no activity.

[r-mettler]

matches INT

[MInthavongsay]

migration and server tests all passed!