Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B-20477 #13341

Merged
merged 29 commits into from
Sep 19, 2024
Merged

B-20477 #13341

merged 29 commits into from
Sep 19, 2024

Conversation

loganwc
Copy link
Contributor

@loganwc loganwc commented Jul 26, 2024 •
edited
Loading

@loganwc loganwc self-assigned this Jul 29, 2024
@loganwc loganwc added G-Unit Scrum Team G MAIN labels Sep 9, 2024
@loganwc loganwc marked this pull request as ready for review September 9, 2024 14:49
@loganwc loganwc requested a review from a team as a code owner September 9, 2024 14:49
traskowskycaci
traskowskycaci approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@traskowskycaci traskowskycaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some small spacing diffs in pkg/handlers/ghcapi/api.go

@pambecker
Copy link
Contributor

Logan, can you take a look at the failing pre_test here?

@pambecker pambecker merged commit 289eb14 into main Sep 19, 2024
41 checks passed
@pambecker pambecker deleted the B-20477 branch September 19, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traskowskycaci traskowskycaci traskowskycaci approved these changes

@pambecker pambecker pambecker approved these changes

@paulstonebraker paulstonebraker Awaiting requested review from paulstonebraker

@joeydoyecaci joeydoyecaci Awaiting requested review from joeydoyecaci

@JonSpight JonSpight Awaiting requested review from JonSpight

Assignees

@loganwc loganwc

Labels
G-Unit Scrum Team G MAIN
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loganwc @pambecker @traskowskycaci